fix(protocol): update amounts emitted to match length with tokenIds #15898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
approved these changes
Feb 18, 2024
dantaik
changed the title
|
@dantaik This will slightly increase the gas usage due to nonzero calldata bytes, but I think it is more correct to require amount = 1 for ERC721. What do you think? |
davidtaikocha
approved these changes
Feb 19, 2024
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TokenReceivedevent should emitamountsof the same length as thetokenIds, even if it is unused for ERC721.I would also recommend enforcing
amount = 1for each ERC721 send insendTokenand updating theTokenReceivedevent to haveamountsjust be an array of 1s. The upside is that it is clear that you are transferring the whole ERC721, instead of unusedamountfield. The downside is gas usage.